fix: SortMergeJoin with unsupported key type should fall back to Spark #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advancedxy
reviewed
Apr 30, 2024
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Apr 30, 2024
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
Outdated
Show resolved
Hide resolved
andygrove
reviewed
Apr 30, 2024
spark/src/test/scala/org/apache/comet/exec/CometJoinSuite.scala
Outdated
Show resolved
Hide resolved
andygrove
approved these changes
Apr 30, 2024
|
As an idea, I was thinking that we could put in tests to check the supported types in Datafusion, so that when we upgrade to a version of datafusion that supports these other types (like timestamp with timezone for example) we are aware that we should change the list of allowed types. |
|
Merged. Thanks. |
|
@planga82 Thanks for the suggestion. I created an issue to track it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #354.
Rationale for this change
What changes are included in this PR?
How are these changes tested?