Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for BuildRight #390

Closed
andygrove opened this issue May 6, 2024 · 2 comments · Fixed by #437
Closed

feat: Add support for BuildRight #390

andygrove opened this issue May 6, 2024 · 2 comments · Fixed by #437
Assignees
@viirya
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

andygrove commented May 6, 2024 •
edited

What is the problem the feature request solves?

We are unable to run a number of TPC-H natively due to the error BuildRight is not supported. The queries affected include q2, q9, q10, q11, and q16.

See code in QueryPlanSerde.

if (join.buildSide == BuildRight) {
  // DataFusion HashJoin assumes build side is always left.
  // TODO: support BuildRight
  withInfo(join, "BuildRight is not supported")
  return None
}

Describe the potential solution

No response

Additional context

No response
@andygrove andygrove added the enhancement New feature or request label May 6, 2024
@andygrove
Copy link
Member Author

Related issue in DataFusion: apache/datafusion#9603

@andygrove andygrove mentioned this issue May 6, 2024
Open
3 tasks
@viirya
Copy link
Member

viirya commented May 14, 2024

I will work on this at DataFusion.

@viirya viirya self-assigned this May 14, 2024
@viirya viirya mentioned this issue May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viirya viirya

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add HashJoin support for BuildRight viirya/arrow-datafusion-comet
2 participants
@viirya @andygrove