Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Union.alias with SubqueryAlias #2213

Closed
Tracked by #474
andygrove opened this issue Apr 12, 2022 · 1 comment
Closed
Tracked by #474

Replace Union.alias with SubqueryAlias #2213

andygrove opened this issue Apr 12, 2022 · 1 comment
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@andygrove
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
In #2172 we added a new SubqueryAlias operator in the logical plan to wrap aliased table scans. This issue is to apply the same approach to unions and remove the alias field from the Union struct.

Describe the solution you'd like
As described above.

Describe alternatives you've considered
None

Additional context
None

@andygrove
Copy link
Member Author

I am no longer sure if this is a good idea. Aliasing can only apply to certain operators. For example, it doesn't make sense to alias a filter operation. I am closing this for now.

@andygrove andygrove added the invalid This doesn't seem right label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
1 participant