Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make type coercion rule more robust #3390

Closed
Tracked by #822 ...
andygrove opened this issue Sep 7, 2022 · 2 comments
Closed
Tracked by #822 ...

Make type coercion rule more robust #3390

andygrove opened this issue Sep 7, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Dask SQL project is seeing this:

Skipping optimizer rule TypeCoercion due to unexpected error: Error during planning: Coercion from [Timestamp(Nanosecond, Some("Europe/Berlin"))] to the signature Variadic([Int64]) failed.

Describe the solution you'd like
It would be better for the rule to return the original expression rather than fail

Describe alternatives you've considered
None

Additional context
None

@andygrove andygrove added the enhancement New feature or request label Sep 7, 2022
@andygrove andygrove self-assigned this Sep 7, 2022
@andygrove
Copy link
Member Author

Also happens in common_sub_expression_eliminate:

Skipping optimizer rule common_sub_expression_eliminate due to unexpected error: Error during planning: 'Timestamp(Nanosecond, None) + Int64' can't be evaluated because there isn't a common type to coerce the types to       

@andygrove
Copy link
Member Author

I think we can close this issue now that there are specific issues filed for optimizer rules that are failing, such as #3797, #3416, #3417, and #3418.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant