Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rewriting subquery expressions in simplify_expressions #3770

Open
andygrove opened this issue Oct 8, 2022 · 1 comment
Open

Support rewriting subquery expressions in simplify_expressions #3770

andygrove opened this issue Oct 8, 2022 · 1 comment
Labels
enhancement New feature or request optimizer Optimizer rules

Comments

@andygrove
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
PR #3764 reverts a regression in optimizing subqueries but does so by running simplify_expressions a second time, after subqueries have been converted to joins.

This is not the ideal solution.

Describe the solution you'd like
simplify_expressions should rewrite subqueries instead. This will support all subqueries, not just the ones that can be converted to joins.

Describe alternatives you've considered
None

Additional context
See conversation #3764 (comment)

@HaoYang670
Copy link
Contributor

Do we need to consider the schema infomation of the parent query when optimizing the subquery?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimizer Optimizer rules
Projects
None yet
Development

No branches or pull requests

2 participants