Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't make dependants install protoc #3947

Closed
avantgardnerio opened this issue Oct 24, 2022 · 0 comments · Fixed by #3950
Closed

Don't make dependants install protoc #3947

avantgardnerio opened this issue Oct 24, 2022 · 0 comments · Fixed by #3950
Labels
enhancement New feature or request

Comments

@avantgardnerio
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

I'd like to file a PR with delta-rs (delta-io/delta-rs#892) but it won't pass their CI because we require all our downstream dependencies to install protoc. Let's fix that.

Describe the solution you'd like

Have build.rs automatically download and extract the correct protoc distribution for the build platform into OUT_DIR and use that for the prost build.

Describe alternatives you've considered

  1. require users to install it manually
  2. PR prost to add this functionality
  3. stop using prost

Additional context
Add any other context or screenshots about the feature request here.
@avantgardnerio avantgardnerio added the enhancement New feature or request label Oct 24, 2022
@avantgardnerio avantgardnerio mentioned this issue Oct 24, 2022
Closed
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Oct 25, 2022
@tustvold
Only require PROTOC for source build (apache#3947)
17af511
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Oct 25, 2022
@tustvold
Only require PROTOC for source build (apache#3947)
1acd449
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Oct 25, 2022
@tustvold
Vendor generated protobuf code (apache#3947)
d1cff05
@tustvold tustvold mentioned this issue Oct 25, 2022
Merged
@avantgardnerio avantgardnerio mentioned this issue Oct 25, 2022
Closed
tustvold added a commit that referenced this issue Oct 27, 2022
@tustvold
Vendor Generated Protobuf Code (#3947) (#3950)
11c5255 
* Vendor generated protobuf code (#3947)

* RAT

* Fix build without json

* Review feedback

* Doc tweak

* Fix Arch install instructions
@alamb alamb mentioned this issue Oct 29, 2022
Closed
2 tasks
Dandandan pushed a commit to yuuch/arrow-datafusion that referenced this issue Nov 5, 2022
@tustvold @Dandandan
Vendor Generated Protobuf Code (apache#3947) (apache#3950)
bcb2315 
* Vendor generated protobuf code (apache#3947)

* RAT

* Fix build without json

* Review feedback

* Doc tweak

* Fix Arch install instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@avantgardnerio