Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OptimizerConfig a Trait #4631

Closed
tustvold opened this issue Dec 14, 2022 · 0 comments · Fixed by #4645
Closed

Make OptimizerConfig a Trait #4631

tustvold opened this issue Dec 14, 2022 · 0 comments · Fixed by #4645
Assignees
@tustvold
Labels
enhancement New feature or request

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Similar to #4629

Describe the solution you'd like

The proliferation of various different config structs (#4349) is confusing, not to mention error prone (#4630)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
@tustvold tustvold added the enhancement New feature or request label Dec 14, 2022
@tustvold tustvold self-assigned this Dec 14, 2022
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Dec 15, 2022
@tustvold
Make OptimizerConfig a trait (apache#4631) (apache#4638)
e9beb6d
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Dec 15, 2022
@tustvold
Make OptimizerConfig a trait (apache#4631) (apache#4638)
1f929f0
tustvold added a commit to tustvold/arrow-datafusion that referenced this issue Dec 15, 2022
@tustvold
Make OptimizerConfig a trait (apache#4631) (apache#4638)
babfb99
@tustvold tustvold mentioned this issue Dec 15, 2022
Merged
tustvold added a commit that referenced this issue Dec 16, 2022
@tustvold
Make OptimizerConfig a trait (#4631) (#4638) (#4645)
ca8985e 
* Make OptimizerConfig a trait (#4631) (#4638)

* Format

* Review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make OptimizerConfig a trait (#4631) (#4638) tustvold/arrow-datafusion
1 participant
@tustvold