fix: RepartitionExec metrics
#10025
Merged
fix: RepartitionExec metrics
#10025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RepartitionExec` is somewhat special. While most execs operate on "input partition = output partition", `RepartitionExec` drives all of its work using input-bound tasks. The metrics "fetch time" and "repartition time" therefore have to be accounted for the input partition, not for the output partition. The only metric that has an input & output partition label is the "send time". Fixes apache#10015.
9 tasks
alamb
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes #10015.
Rationale for this change
RepartitionExecis somewhat special. While most execs operate on "input partition = output partition",RepartitionExecdrives all of its work using input-bound tasks. The metrics "fetch time" and "repartition time" therefore have to be accounted for the input partition, not for the output partition. The only metric that has an input & output partition label is the "send time".What changes are included in this PR?
Metrics fixed.
Are these changes tested?
-
Are there any user-facing changes?
Metrics make sense now.