Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cast array test to sqllogictest #10474

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

viirya
Copy link
Member

@viirya viirya commented May 12, 2024

Which issue does this PR close?

Closes #10464.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alamb
Copy link
Contributor

alamb commented May 13, 2024

@jonahgao perhaps you would like to try merging this PR as a test that we have all the permissions setup correctly ?

@jonahgao
Copy link
Member

@jonahgao perhaps you would like to try merging this PR as a test that we have all the permissions setup correctly ?

Sure.

@jonahgao jonahgao merged commit 5fac581 into apache:main May 13, 2024
23 checks passed
@jonahgao
Copy link
Member

Thanks @viirya and thank you @alamb for letting me experience this.

@viirya
Copy link
Member Author

viirya commented May 13, 2024

Thank you @alamb @jonahgao

@viirya viirya deleted the add_cast_test branch May 13, 2024 14:23
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: CAST(<array>) causes internal error
3 participants