Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate testing optimizer rules to use rewrite API #10576

Merged
merged 3 commits into from
May 21, 2024
Merged

Migrate testing optimizer rules to use rewrite API #10576

merged 3 commits into from
May 21, 2024

Conversation

lewiszlw
Copy link
Member

Which issue does this PR close?

part of #9637.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the optimizer Optimizer rules label May 20, 2024
@alamb alamb changed the title Migrate testing optimizer rules Migrate testing optimizer rules to use rewrite API May 20, 2024
alamb
alamb approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you (again) @lewiszlw -- this looks great.

I wonder if it is time to deprecate OptimizerRule::try_optimize

@lewiszlw
Copy link
Member Author

The CommonSubexprEliminate rule has not been migrated yet.

@alamb
Copy link
Contributor

alamb commented May 21, 2024

The CommonSubexprEliminate rule has not been migrated yet.

That is a good point -- though we could do something like #[allow(deprecated)] until it is. I hope to work on it over the next week or two

@alamb alamb merged commit f807947 into apache:main May 21, 2024
24 checks passed
@alamb
Copy link
Contributor

alamb commented May 21, 2024

Thanks again @lewiszlw

@alamb alamb mentioned this pull request May 28, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
optimizer Optimizer rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lewiszlw @alamb