Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert StringAgg to UDAF #10945

Merged
merged 11 commits into from
Jun 18, 2024
Merged

Convert StringAgg to UDAF #10945

merged 11 commits into from
Jun 18, 2024

Conversation

lewiszlw
Copy link
Member

Which issue does this PR close?

part of #8708.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions physical-expr Physical Expressions sqllogictest labels Jun 17, 2024
@lewiszlw lewiszlw changed the title Convert string agg to udaf Convert StringAgg to udaf Jun 17, 2024
@lewiszlw lewiszlw changed the title Convert StringAgg to udaf Convert StringAgg to UDAF Jun 17, 2024
jayzhan211
jayzhan211 reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, remember to add test in roundtrip_expr_api

datafusion/functions-aggregate/src/string_agg.rs Outdated Show resolved Hide resolved
datafusion/proto/tests/cases/roundtrip_physical_plan.rs Show resolved Hide resolved
@lewiszlw lewiszlw requested a review from jayzhan211 June 18, 2024 05:54
jayzhan211
jayzhan211 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

alamb
alamb approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lewiszlw and @jayzhan211

@alamb alamb merged commit a873f51 into apache:main Jun 18, 2024
23 checks passed
@jayzhan211 jayzhan211 mentioned this pull request Jun 19, 2024
Open
@alamb alamb added the api change Changes the API exposed to users of the crate label Jul 9, 2024
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
@lewiszlw @findepi
Convert StringAgg to UDAF (apache#10945)
3d10036 
* Convert StringAgg to UDAF

* generate proto code

* Fix bug

* Fix

* Add license

* Add doc

* Fix clippy

* Remove aliases field

* Add StringAgg proto test

* Add roundtrip_expr_api test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@jayzhan211 jayzhan211 jayzhan211 approved these changes

Assignees
No one assigned
Labels
api change Changes the API exposed to users of the crate logical-expr Logical plan and expressions physical-expr Physical Expressions sqllogictest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lewiszlw @alamb @jayzhan211