Support to unparse ScalarValue::TimestampNanosecond to String
#10984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jun 18, 2024
datafusion/sql/src/unparser/expr.rs
Outdated
Comment on lines
836
to
843
| Ok(ast::Expr::Cast { | ||
| kind: ast::CastKind::Cast, | ||
| expr: Box::new(ast::Expr::Value(ast::Value::SingleQuotedString( | ||
| result.to_string(), | ||
| ))), | ||
| data_type: ast::DataType::Timestamp(None, TimezoneInfo::None), | ||
| format: None, | ||
| }) |
There was a problem hiding this comment.
I think this code is repeated in both branches -- we could probably avoid the replication
There was a problem hiding this comment.
Thanks, @alamb, for reminding me of this point. I forgot to refactor this part.
|
Thanks @alamb |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…he#10984) * support unparse TimestampNanosecond * cargo fmt * extract the duplicate code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #10796 .
Rationale for this change
What changes are included in this PR?
Instead of
array_value_to_string, I just follow how to convertdatetimetype because I found the timestamp string converted by the arrow formatter would bebut I think the result generated by
datetime::to_stringis more suitable for SQLAre these changes tested?
Yes
Are there any user-facing changes?