Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push down filter plan for unnest on non-unnest column only #10991

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

jayzhan211
Copy link
Contributor

@jayzhan211 jayzhan211 commented Jun 19, 2024

Which issue does this PR close?

Closes #10989 Closes #10990 .

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
@github-actions github-actions bot added optimizer Optimizer rules sqllogictest labels Jun 19, 2024
@jayzhan211 jayzhan211 marked this pull request as ready for review June 19, 2024 07:50
Copy link
Member

@jonahgao jonahgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Maybe we can push down the part of the predicate that does not contain exec_columns?
For example in query

select ua from (select unnest(a) as ua, 1 as b from t) where ua > 3 and b > 1;

We can push down b > 1.

@alamb
Copy link
Contributor

alamb commented Jun 19, 2024

Looks good to me!

Maybe we can push down the part of the predicate that does not contain exec_columns? For example in query

select ua from (select unnest(a) as ua, 1 as b from t) where ua > 3 and b > 1;

We can push down b > 1.

I filed #11016 to track this item

@alamb alamb merged commit 61e2ddb into apache:main Jun 19, 2024
24 checks passed
@alamb
Copy link
Contributor

alamb commented Jun 19, 2024

Thanks @jayzhan211 and @jonahgao

@jayzhan211 jayzhan211 deleted the fix-unnest-pushdownf branch June 19, 2024 23:49
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jun 22, 2024
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
xinlifoobar pushed a commit to xinlifoobar/datafusion that referenced this pull request Jun 22, 2024
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants