Improve GetIndexedFieldExpr adding utf8 key based access for struct v… #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houqp
approved these changes
Nov 1, 2021
|
@houqp Maybe I should add this feature to the docs ? https://arrow.apache.org/datafusion/user-guide/sql/index.html |
|
@Igosuki i think it's a good idea to add it to the sql reference actually. The fact that parquet reader doesn't support nested types is not relevant to sql reference. I think it should work just fine with JSON reader at least? |
|
@houqp Since the JSON reader supports nested data yes it should work without issues. |
alamb
approved these changes
Nov 2, 2021
| ctx.register_table("structs", table_a)?; | ||
|
|
||
| // Original column is micros, convert to millis and check timestamp | ||
| let sql = "SELECT some_struct[\"bar\"] as l0 FROM structs LIMIT 3"; |
|
Filed #1222 to track doc update |
|
Thanks again @Igosuki ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alues
Which issue does this PR close?
Closes #119
Rationale for this change
Adds struct value support to select nested fields. With this, users can access arbitrary nested values in lists and structs which should cover most uses cases.
What changes are included in this PR?
GetIndexedFieldExpr gets StructArray support, allowing
select struct_col["bar"][0] from structsAre there any user-facing changes?
Nope