-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement EXTRACT expression with week, month, day, hour #1974
Conversation
@alamb @liukun4515 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ted-Jiang and @jimexist
); | ||
test_expression!("date_part('WEEK', CAST('2003-01-01' AS DATE))", "1"); | ||
|
||
//TODO Creating logical plan for 'SELECT EXTRACT(WEEK FROM to_timestamp('2020-09-08T12:00:00+00:00'))' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many keywords got added in sqlparser-rs/sqlparser-rs#427 from @mobuchowski (👋 ) but sadly it seems to be missing week
😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't believe I missed it... 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't meant to make you feel bad @mobuchowski -- mostly I was trying to give you props for adding stuff to sqlparser ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry, that's not how I received it 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ted-Jiang Maybe you can file a pr to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liukun4515 @liukun4515 @mobuchowski i would like to add this , it's a good chance to start familiar sqlparser
😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the later response. |
Thanks @Ted-Jiang -- I hope to spend some non trivial amount of time this weekend reviewing and merging PRs |
Which issue does this PR close?
Closes #1896.
Rationale for this change
Already add compute method in
arrow-rs
PR.But found
will fix
EXTRACT(WEEK FROM to_timestamp('2020-09-08T12:00:00+00:00'))
insqlparser
What changes are included in this PR?
Are there any user-facing changes?