Don't treat Null as UTF8(None) and change error info. #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liukun4515
force-pushed
the
inList_UTF_null_#2782
branch
from
305c606
to
68566b0
Compare
liukun4515
commented
Jun 27, 2022
| @@ -111,8 +111,7 @@ macro_rules! make_contains { | |||
| ColumnarValue::Scalar(s) => match s { | |||
| ScalarValue::$SCALAR_VALUE(Some(v)) => Some(*v), | |||
| ScalarValue::$SCALAR_VALUE(None) => None, | |||
| ScalarValue::Utf8(None) => None, | |||
There was a problem hiding this comment.
#2764 merged, we don't need to treat Null as UTF8(None).
liukun4515
commented
Jun 27, 2022
| @@ -111,8 +111,7 @@ macro_rules! make_contains { | |||
| ColumnarValue::Scalar(s) => match s { | |||
| ScalarValue::$SCALAR_VALUE(Some(v)) => Some(*v), | |||
| ScalarValue::$SCALAR_VALUE(None) => None, | |||
| ScalarValue::Utf8(None) => None, | |||
| datatype => unimplemented!("Unexpected type {} for InList", datatype), | |||
| datatype => unreachable!("InList can't reach other data type {} for {}.", datatype, s), | |||
There was a problem hiding this comment.
the expr and list_expr has the same data type, the code can't reach this point
xudong963
approved these changes
Jun 27, 2022
viirya
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2782
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?