add integration test to compare datafusion-cli against psql #281
Conversation
|
this relies on #282 to be resolved first |
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
==========================================
- Coverage 75.72% 75.71% -0.02%
==========================================
Files 143 143
Lines 23910 23927 +17
==========================================
+ Hits 18107 18117 +10
- Misses 5803 5810 +7
Continue to review full report at Codecov.
|
jimexist
force-pushed
the
add-postgres-integration-test
branch
8 times, most recently
from
91c0cc4
to
aead845
Compare
|
so far the diff isn't readable, but we'll switch to csv (#289 ) mode so that we can compare. |
jimexist
changed the title
jimexist
force-pushed
the
add-postgres-integration-test
branch
from
aead845
to
74b7132
Compare
There was a problem hiding this comment.
This is really cool. The output of the job looks good to me
https://github.com/apache/arrow-datafusion/pull/281/checks?check_run_id=2551057118
Though as @Dandandan says it should probably error when there is a diff
| name: "Integration Test" | ||
| needs: [linux-build-lib] | ||
| runs-on: ubuntu-latest | ||
| services: |
There was a problem hiding this comment.
this is cool to use a github actions service. 👍
| @@ -0,0 +1,77 @@ | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
This is really cool -- thank you @jimexist . It reminds me of pg_regres 👍
This script is simple enough that we can always rewrite it in Rust if we would prefer to reduce the number of languages used, but python is a good choice for scripting I think as we already have the python bindings as well as some dev scripts in python.
Will try to create a separate pull request to address the issue of turning off timing printlines |
|
@alamb @Dandandan updated to use |
jimexist
force-pushed
the
add-postgres-integration-test
branch
4 times, most recently
from
6c4baad
to
f185486
Compare
jimexist
force-pushed
the
add-postgres-integration-test
branch
from
f185486
to
2e30324
Compare
jimexist
force-pushed
the
add-postgres-integration-test
branch
2 times, most recently
from
6a4a68c
to
5af2a1c
Compare
jimexist
force-pushed
the
add-postgres-integration-test
branch
6 times, most recently
from
e8ea74d
to
b6591f5
Compare
jimexist
force-pushed
the
add-postgres-integration-test
branch
from
b6591f5
to
f0a6cb3
Compare
|
What do we think @Dandandan -- shall we merge this PR? I feel like in general the DataFusion testing story could use some consolidation / writeup (we now have tests in sql.rs, exec.rs, and now here). However, I don't think I will have time to do anything major for a while (until I get the arrow release process running like a 🚋 ) |
|
I think we should merge this PR! I also feel some consolidation would be very helpful. This PR seems to me it can help a lot with testing against PostgreSQL, something we don't do ATM. |
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example
Closes #123indicates that this PR will close issue #123.Closes #.
Rationale for this change
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
What changes are included in this PR?
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please add the
breaking changelabel.