Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ParquetExec logical expr. => phys. expr. #5419

Merged
merged 4 commits into from
Mar 1, 2023
Merged

refactor: ParquetExec logical expr. => phys. expr. #5419

merged 4 commits into from
Mar 1, 2023

Commits on Mar 1, 2023

  1. feat: get_phys_expr_columns util

    @crepererum
    crepererum committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    0ef5906 View commit details
    Browse the repository at this point in the history

  2. feat: add reassign_predicate_columns util

    @crepererum
    crepererum committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    afb03c8 View commit details
    Browse the repository at this point in the history

  3. feat: PhysicalExprRef type alias

    @crepererum
    crepererum committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    bc5d03f View commit details
    Browse the repository at this point in the history

  4. refactor: ParquetExec logical expr. => phys. expr. 

    Use `Arc<dyn PhysicalExpr>` instead of `Expr` within `ParquetExec` and
move lowering from logical to physical expression into plan lowering
(e.g. `ListingTable`).

This is in line w/ all other physical plan nodes (e.g. `FilterExpr`) and
simplifies reasoning within physical optimizer but also allows correct
passing of `ExecutionProps` into the conversion.

Closes apache#4695.
    @crepererum
    crepererum committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    b909edf View commit details
    Browse the repository at this point in the history