Return plan error when adding utf8 and timestamp #5696
Conversation
github-actions
bot
added
core
There was a problem hiding this comment.
Thanks for the quick fix @Weijun-H -- while the behavior is still not ideal I think this PR is an improvement (as the error is no longer internal) 👍
Longer term I think we will need to improve interval arithmetic but that will be a larger project (one I hope to sketch out more later today)
| @@ -1213,6 +1214,13 @@ pub fn binary( | |||
| ) -> Result<Arc<dyn PhysicalExpr>> { | |||
| let lhs_type = &lhs.data_type(input_schema)?; | |||
| let rhs_type = &rhs.data_type(input_schema)?; | |||
| if (is_utf8_or_large_utf8(lhs_type) && is_timestamp(rhs_type)) | |||
There was a problem hiding this comment.
Thanks @Weijun-H -- this does indeed fix the bug as stated.
I was trying to figure out how this code even executes (and was not caught earlier)
It seems like maybe this could be related to
🤔
Maybe it is time to figure out a better coercion story
There was a problem hiding this comment.
+1 sometime ago we agreed to that logical planner will be a better place for coercions and coercion checks
Which issue does this PR close?
Closes #5650
Rationale for this change
What changes are included in this PR?
Return plan error when performing binary operations between timestamp and utf8
Are these changes tested?
Are there any user-facing changes?