fix: coerce text to timestamps with timezones #7720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the type coercion logic used with function calls to enable text respresentaions of timestamps to be coerced to a timestamp type with a timezone. If there is no other suitable choice the timezone will be "+00" (UTC). The specific use case for this change is to allow the third (offset) parameter of the date_bin function to be specified as a constant srting when the input array for the second parameter has a specitied time zone.
alamb
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Thank you @mhilton -- I think this code does what it says and fixes the problem described nicely
I think the +TZ thing is a little magic and I would like to pull it into its own named constant (with a comment explaining what is going on to make that more discoverable). Maybe I can do that as a follow on PR if you prefer
Create a named constant for the placeholder timezone as suggested in the review.
alamb
approved these changes
Oct 2, 2023
|
I made a follow on PR with some documentation and naming improvments: #7726 |
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
Oct 7, 2023
* fix: coerce text to timestamps with timezones Extend the type coercion logic used with function calls to enable text respresentaions of timestamps to be coerced to a timestamp type with a timezone. If there is no other suitable choice the timezone will be "+00" (UTC). The specific use case for this change is to allow the third (offset) parameter of the date_bin function to be specified as a constant srting when the input array for the second parameter has a specitied time zone. * review comments Create a named constant for the placeholder timezone as suggested in the review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7697.
Rationale for this change
The specific use case for this change is to allow the third (offset) parameter of the date_bin function to be specified as a constant string when the input array for the second parameter has a specified time zone.
What changes are included in this PR?
Extend the type coercion logic used with function calls to enable text respresentaions of timestamps to be coerced to a timestamp type with a timezone. If there is no other suitable choice the timezone will be "+00" (UTC).
Are these changes tested?
Yes
Are there any user-facing changes?
Strictly speaking this changes the behaviour in a way a user might notice, not in a way that requires changes to the documentation though.