Implement Aliases for ScalarUDF #8360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: veeupup <code@tanweime.com>
github-actions
bot
added
logical-expr
|
@alamb PTAL : ) I'm considering that whether we need to provide a helper function |
edmondop
reviewed
Nov 29, 2023
| @@ -341,6 +341,43 @@ async fn case_sensitive_identifiers_user_defined_functions() -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn test_user_defined_functions_with_alias() -> Result<()> { | |||
There was a problem hiding this comment.
Maybe useful to test again the case where you create a udf1 with an alias and then a different udf with the same alias? I don't know what's the expected behavior there
There was a problem hiding this comment.
the behavior will be like HashMap::insert, the old value of the same alias will be updated with the new udf
8 tasks
Signed-off-by: veeupup <code@tanweime.com>
Veeupup
force-pushed
the
alias_for_scalar_udf
branch
from
71ca93a
to
f495f77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8348
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?