Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TTY during bench data generation #9626

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

gruuya
Copy link
Contributor

@gruuya gruuya commented Mar 15, 2024

Which issue does this PR close?

Should close #9620.

Rationale for this change

Try a workaround for missing TTY from actions/runner#241

What changes are included in this PR?

Shell used to run the bench data gen step.

Are these changes tested?

They are on our fork (though that worked before too): splitgraph#2

Are there any user-facing changes?

@gruuya
Copy link
Contributor Author

gruuya commented Mar 15, 2024

/benchmark

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gruuya -- let's try it out and keep iterating/testing on master

@Dandandan Dandandan merged commit 3d13091 into apache:main Mar 16, 2024
23 checks passed
@gruuya gruuya deleted the fix-ci-bench-tty branch March 16, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/benchmark command seems not to work
3 participants