-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The library is not UBSan friendly. #211
Comments
Do you have a minimum test case that fails? I was unable to reproduce this when running locally. |
@jmalkin It may or may not fail depending on platform and compiler. UBSan catches undefined behavior that potentially might fail somewhere. |
@alexey-milovidov Would you like to submit a pull request or would you like us to apply your suggested patch? Thank you. |
@AlexanderSaydakov yes, I added flags to compile and link with UBSan and ASan using |
It's ok if you commit this patch under your name. My collegue will share an example, but only tomorrow. |
Unaligned memory access: 6ea39e3
This issue has been found while we tried to integrate the library to ClickHouse.
ClickHouse is tested with ASan, MSan, TSan and UBSan with several kinds of continuous fuzzing.
The text was updated successfully, but these errors were encountered: