Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The library is not UBSan friendly. #211

Closed
alexey-milovidov opened this issue Apr 20, 2021 · 5 comments · Fixed by #213
Closed

The library is not UBSan friendly. #211

alexey-milovidov opened this issue Apr 20, 2021 · 5 comments · Fixed by #213

Comments

@alexey-milovidov
Copy link
Contributor

alexey-milovidov commented Apr 20, 2021

Unaligned memory access: 6ea39e3

This issue has been found while we tried to integrate the library to ClickHouse.
ClickHouse is tested with ASan, MSan, TSan and UBSan with several kinds of continuous fuzzing.

@jmalkin
Copy link
Contributor

jmalkin commented Apr 20, 2021

Do you have a minimum test case that fails? I was unable to reproduce this when running locally.

@AlexanderSaydakov
Copy link
Contributor

@jmalkin It may or may not fail depending on platform and compiler. UBSan catches undefined behavior that potentially might fail somewhere.

@AlexanderSaydakov
Copy link
Contributor

@alexey-milovidov Would you like to submit a pull request or would you like us to apply your suggested patch? Thank you.

@jmalkin
Copy link
Contributor

jmalkin commented Apr 21, 2021

@AlexanderSaydakov yes, I added flags to compile and link with UBSan and ASan using -fcoverage options and found nothing. I may well be doing something incorrectly, of course.

@alexey-milovidov
Copy link
Contributor Author

It's ok if you commit this patch under your name. My collegue will share an example, but only tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants