CPC max serialized size bytes #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 958299487
💛 - Coveralls |
will-lauer
approved these changes
Jun 16, 2021
will-lauer
approved these changes
Jun 17, 2021
jmalkin
approved these changes
Jun 21, 2021
cpc/include/cpc_sketch_impl.hpp
Outdated
| template<typename A> | ||
| size_t cpc_sketch_alloc<A>::get_max_serialized_size_bytes(uint8_t lg_k) { | ||
| check_lg_k(lg_k); | ||
| if (lg_k <= 19) return CPC_EMPIRICAL_MAX_SIZE_BYTES[lg_k - 4] + 40; |
There was a problem hiding this comment.
Might be clearer to use CPC_MIN_LG_K instead of 4. And should we define a preamble size constant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.