Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed static tests replaced by dynamic ones #391

Merged
merged 7 commits into from
Aug 24, 2023
Merged

removed static tests replaced by dynamic ones #391

merged 7 commits into from
Aug 24, 2023

Conversation

AlexanderSaydakov
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5883555249

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 98.962%
Files with Coverage Reduction New Missed Lines %
theta/include/compact_theta_sketch_parser_impl.hpp 2 80.85%
common/include/bounds_binomial_proportions.hpp 3 93.94%
Totals Coverage Status
Change from base Build 5859788548: -0.03%
Covered Lines: 15629
Relevant Lines: 15793
💛 - Coveralls

jmalkin
jmalkin approved these changes Aug 19, 2023
View reviewed changes
Copy link
Contributor

@jmalkin jmalkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure what's meant by one comment but not a blocker.

kll/test/kll_sketch_deserialize_from_java_test.cpp
@@ -75,4 +75,29 @@ TEST_CASE("kll double", "[serde_compat]") {
}
}

// numbers are padded with leading spaces so that natural order works
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is automatic in the serde? there doesn't seem to be anything in the code that'd handle that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is how it was done on the Java side during sketch updates presumably to avoid supplying a custom comparator

@AlexanderSaydakov AlexanderSaydakov merged commit 52588ac into master Aug 24, 2023
7 checks passed
@AlexanderSaydakov AlexanderSaydakov deleted the java_serde_compat_testing branch August 24, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmalkin jmalkin jmalkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexanderSaydakov @coveralls @jmalkin