Generate sketches for java #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6032795106
💛 - Coveralls |
jmalkin
approved these changes
Aug 31, 2023
| for (unsigned i = 1; i <= n; ++i) sketch.update(std::to_string(i)); | ||
| REQUIRE(sketch.is_empty() == (n == 0)); | ||
| if (n > 10) { | ||
| // REQUIRE(sketch.get_maximum_error() > 0); |
There was a problem hiding this comment.
forgot to uncomment after some experiment
| TEST_CASE("varopt sketch long sampling", "[serialize_for_java]") { | ||
| var_opt_sketch<long> sketch(1024); | ||
| for (unsigned i = 0; i < 2000; ++i) sketch.update(i); | ||
| // heavy items have negative weights to allow a simple predicate to filter |
There was a problem hiding this comment.
This was an error in the comment in the original test. Negative values, not weights.
|
|
||
| namespace datasketches { | ||
|
|
||
| TEST_CASE("var opt union doulbe sampling", "[serialize_for_java]") { |
| // small k sketch, but sampling | ||
| var_opt_sketch<double> sketch1(k_small); | ||
| for (unsigned i = 0; i < n1; ++i) sketch1.update(i); | ||
| // heavy items have negative weights to allow a simple predicate to filter |
|
|
||
| TEST_CASE("theta sketch generate non-empty no entries", "[serialize_for_java]") { | ||
| auto sketch = update_theta_sketch::builder().set_p(0.01).build(); | ||
| sketch.update(1); |
There was a problem hiding this comment.
We do this for AOD, too. It does depend on the hash function vs p=0.01. I don't think it's critical but it is conditioning a test on an an implicit assumption around the hash function.
There was a problem hiding this comment.
right, but because 1 always has the same hash, and the test passes, it will stay that way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.