better naming, no forced compression #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7935029387Details
💛 - Coveralls |
jmalkin
approved these changes
Feb 20, 2024
| if (upper == centroids_.begin()) throw std::logic_error("upper == begin in get_rank()"); | ||
| if (value < lower->get_mean()) --lower; | ||
| if (upper == centroids_.end() || (upper != centroids_.begin() && !((upper - 1)->get_mean() < value))) --upper; | ||
| if (upper == centroids_.end() || !((upper - 1)->get_mean() < value)) --upper; |
There was a problem hiding this comment.
Not sure what this does so I'll have to trust that it's correct
There was a problem hiding this comment.
there is a check already just above that if (upper == begin) throw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.