Skip to content
Permalink
Browse files
Update FindBugs Exclude Filter in tools/
  • Loading branch information
leerho committed Jun 17, 2019
1 parent 540c0f5 commit 4f86fe1c18443c5402e09584c8e4e54b41585450
Showing 1 changed file with 1 addition and 16 deletions.
@@ -1,25 +1,10 @@
<FindBugsFilter> <!-- sketches-core -->
<FindBugsFilter> <!-- memory -->

<!-- Too many false positives to be useful. I could not make it happy :( -->
<Match>
<Bug pattern="SF_SWITCH_NO_DEFAULT" />
</Match>

<!-- False positive. FindBugs complains if DQS_RESIZE_THRESHOLD == REBUILD_THRESHOLD,
but this allows us to tune these constants for different sketches. -->
<Match>
<Bug pattern="DB_DUPLICATE_BRANCHES" />
<Class name="com.yahoo.sketches.theta.DirectQuickSelectSketch" />
<Method name="setHashTableThreshold" />
</Match>

<!-- False positive. In this case we want to ignore the exceptions -->
<Match>
<Bug pattern="DE_MIGHT_IGNORE" />
<Class name="com.yahoo.sketches.theta.PairwiseCornerCasesTest" />
<Method name="checkNotOrdered" />
</Match>

<Match> <!-- Exclude for test classes; too many False Positives. -->
<Bug pattern="NP_NULL_PARAM_DEREF_NONVIRTUAL" />
<Class name="~.*\.*Test" />

0 comments on commit 4f86fe1

Please sign in to comment.