Jdo 709 #20
Merged
Jdo 709 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaeschke
reviewed
Apr 28, 2021
| /** | ||
| * PCRect2'S ObjectId class. | ||
| */ | ||
| public static class Oid implements Serializable { |
There was a problem hiding this comment.
Do we need this Oid class?
There was a problem hiding this comment.
We need an Oid class for applicationidentity.
There was a problem hiding this comment.
I replaced the Oid class by using SingleFieldIdentity. Now the RCRectString metadata defines javax.jdo.identity.LongIdentity as ObjectId class.
| @@ -38,7 +38,7 @@ | |||
|
|
|||
| <!-- TCK Loggers --> | |||
|
|
|||
| <Logger name="org.apache.jdo.tck" level="info" additivity="false"> | |||
| <Logger name="org.apache.jdo.tck" level="debug" additivity="false"> | |||
There was a problem hiding this comment.
That looks like an unrelated change. Is it intended?
There was a problem hiding this comment.
Good catch! This change is not intended. I will revert this.
| * | ||
| * @author Michael Bouschen | ||
| */ | ||
| public class PCRect2 { |
There was a problem hiding this comment.
Should we call it PCRectString or something instead of PCRect2? That may be more descriptive.
tobous
reviewed
Apr 29, 2021
tck/src/main/java/org/apache/jdo/tck/pc/mylib/PCRectString.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/apache/jdo/tck/pc/mylib/PCRectString.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/apache/jdo/tck/pc/mylib/PCRectString.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/apache/jdo/tck/pc/mylib/PCRectString.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/apache/jdo/tck/pc/mylib/PCRectString.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/apache/jdo/tck/pc/mylib/PCRectString.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Tobias Bouschen <tobias.bouschen@googlemail.com>
… removed code in comment Co-authored-by: Tobias Bouschen <tobias.bouschen@googlemail.com>
… for PCRectString class Co-authored-by: Tilmann <tilmannz@apache.org>
Co-authored-by: Tobias Bouschen <tobias.bouschen@googlemail.com> Co-authored-by: Tobias Bouschen <tobias.bouschen@googlemail.com>
clr-apache
reviewed
Apr 29, 2021
| * PersistenceCapable class to test JDO AttributeConverter interface. | ||
| * It#s fields of type Point are converted to strins in the datastore. | ||
| * | ||
| * @author Michael Bouschen |
There was a problem hiding this comment.
Generally, @author tags are not used in Apache code anywhere.
- Added separate test cases for storing and reading a PCRectString instance - Added new test case for modifying a PCRectString instance - AttributeConverter implementation moved from static nested class of PCRectString to util package - Added helper method to create PCRectString instances to TCK test class - Removed author tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a TCK test case for the AttributeConverter interface.
The persistent capable class PCRect2 has two fields of type Point. A point consists of two integer fields (x, y) and is not persistent capable. Each PCRect2 point instance is mapped to a string of the form "x:y". So the DB schema for PCRect2 has two VARCHAR columns. PCRect2 has a static nested class PointToStringConverter that implements the JDO AttributeConverter interface and implements the conversion from a point to a string and vice versa.
The TCK Test class AttributeConverterTest has two test methods.
The AttributeConverter implementation has static fields to count the number of converter calls. This allows the test class to check whether the converter methods are called.