Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DELTASPIKE-1203:jpa example #65

Closed
wants to merge 2 commits into from

Conversation

subaochen
Copy link
Contributor

hi,

Here is the basic Deltaspike JPA example, please double check it, thanks!

@subaochen
Copy link
Contributor Author

Here there are two questions need to discuss:
1, there is only one business logic layer: ArticleController, no bean layer, no service layer. Should I seperate ArticleController into ArticleBean and ArticleService ?

2, I put @ViewScoped onto ArticleController, because from article list page(list.xhtml), we can click "edit" link to go to add.xhtml to edit the slelected article, so we must merge the article when click the save button, that is why I use @ViewScoped. It seemed that, WindowScoped or ViewAccessScoped should also works. I don't know how to make it work when used @RequestScoped, any idea?

thanks!

@johnament
Copy link
Contributor

Hi, sorry for the delay in looking at this. The problem at this point is your PRs are in conflict with one another. In one you're adding wildfly plugin 1.0.1 and the other 1.1.0. Which is intended?

@johnament
Copy link
Contributor

Ok, i think I got it. But I had to rebase the commits. Please close this PR.

@subaochen subaochen closed this Oct 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants