DIRSTUDIO-1309: Upgrade to Eclipse 4.24 #43
Conversation
|
Thanks, Frederick! If someone volunteers to tun self-hosted GitHub M1 runner, that would help |
|
To get things started, maybe you could just take my word for it that this works on M1. Then you'd only need to verify that it doesn't break any of the existing platforms. Going forward, automated testing will of course be needed to prevent accidental regressions, but that is unfortunately not something that I could help out with, but once M1 support has been added and people start using it, maybe someone else will step up and help out, when they then have an interest in keeping it working. |
|
Hi Frederick, just merged your change! I'll check if that breaks anything on i386. |
Great! How is it going, are you finding any unexpected side-effects? |
|
@roubert Have you get Shawn McKinney mail? |
Yes, thank you. |
roubert
changed the title
|
As I had this commit prepared, I've now updated the commit message in case you'd like to use it to update to Eclipse 4.24 (even though it now isn't needed to support Apple silicon anymore, after PR #36 was merged earlier today). |
roubert
changed the title
|
I've now filed a separate ticket DIRSTUDIO-1309 specifically about updating the Eclipse platform used (unrelated to Apple silicon) and repurposed this PR for that. |
GitHub might just have solved that: https://github.blog/changelog/2023-10-02-github-actions-apple-silicon-m1-macos-runners-are-now-available-in-public-beta/ |
|
@PierreSmits, now when you're upgrading dependencies, you might want to also merge this PR. |
|
Hi @roubert According to my information you are a committer to this repository also. As such you can merge (valid) pull-request too. However, I suggest to do a dummy commit to get this PR tested against latest changes in the main branch (given the age of this PR and recent upgrades). |
This is the last version of Eclipse using Java 11.
|
Well, I'm not used to merging things like a lone ranger, without anyone else in the project first reviewing and agreeing. But I've now rebased and will force push, to trigger tests at current master. |
roubert
force-pushed
the
dirstudio-1293
branch
from
e3ae978
to
4080377
Compare
|
Hi @roubert, please go ahead ! Break things, then get them fixed - either by you are someone else -. Don't be shy :-) |
|
Thanks @elecharny My thoughts exactly. Our CI processes should safeguard that what gets merged in our trunk is good enough. |
This is an alternate version of PR #36 in case the maintainers would prefer to keep using explicit version numbers here.
All unit tests (including
-Denable-ui-tests) pass. Also tested manually on an M1 Mac with macOS Ventura 13.3.1 (a).Eclipse 4.24 is chosen because it's the newest version to which these libraries can be upgraded without having to make any other changes. Eclipse 4.25 causes a dependency error with JUnit (which eventually will need to be resolved, but isn't anything that needs to be done in order to resolve the Apple silicon issue).