Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: compatible ruff latest version #144

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

zhongjiajie
Copy link
Member

our ci fail with latest version of ruff in step lint
https://github.com/apache/dolphinscheduler-sdk-python/actions/runs/8841147449/job/24277780100

Brief Summary of The Change

Pull Request checklist

I confirm that the following checklist has been completed.

  • Add/Change test cases for the changes.
  • Add/Change the related documentation, should also change docs/source/config.rst when you change file default_config.yaml.
  • (Optional) Add your change to UPDATING.md when it is an incompatible change.

@zhongjiajie zhongjiajie added the chore A collection of chore like CI, remove not used code label Apr 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 90.88%. Comparing base (2f1f2c4) to head (7818d2e).

Files Patch % Lines
src/pydolphinscheduler/core/yaml_workflow.py 66.66% 3 Missing ⚠️
src/pydolphinscheduler/resources_plugin/github.py 0.00% 1 Missing ⚠️
src/pydolphinscheduler/resources_plugin/gitlab.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   90.88%   90.88%           
=======================================
  Files          64       64           
  Lines        2371     2371           
=======================================
  Hits         2155     2155           
  Misses        216      216           
Flag Coverage Δ
unittests 90.88% <54.54%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhongjiajie zhongjiajie merged commit a7ce874 into apache:main Apr 26, 2024
22 checks passed
@zhongjiajie zhongjiajie deleted the ruff-auto-lint branch April 26, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A collection of chore like CI, remove not used code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants