New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Change class name from process definition to workflow #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 90.65% 90.68% +0.02%
==========================================
Files 57 59 +2
Lines 2055 2072 +17
==========================================
+ Hits 1863 1879 +16
- Misses 192 193 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhongjiajie
added
dep-main-repo
Dependent on repository apache/dolphinscheduler
incompatible
labels
Nov 16, 2022
Should not merged until #15 merged, we need to change its keyword as well |
we should change the class keyword from `process definition` to `workflow` fix: apache#22
zhongjiajie
force-pushed
the
i-ch-name-wf
branch
from
November 16, 2022 11:56
3300162
to
51f1c99
Compare
caishunfeng
approved these changes
Nov 16, 2022
released after apache/dolphinscheduler:3.1.2 |
zhongjiajie
removed
the
dep-main-repo
Dependent on repository apache/dolphinscheduler
label
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary of The Change
we should change the class keyword from
process definition
toworkflow
fix: #22
Pull Request checklist
I confirm that the following checklist has been completed.
docs/source/config.rst
when you change filedefault_config.yaml
.UPDATING.md
when it is an incompatible change.