Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Change class name from process definition to workflow #26

Merged
merged 12 commits into from Nov 16, 2022

Conversation

zhongjiajie
Copy link
Member

Brief Summary of The Change

we should change the class keyword from process definition to workflow

fix: #22

Pull Request checklist

I confirm that the following checklist has been completed.

  • Add/Change test cases for the changes.
  • Add/Change the related documentation, should also change docs/source/config.rst when you change file default_config.yaml.
  • (Optional) Add your change to UPDATING.md when it is an incompatible change.

@zhongjiajie zhongjiajie added the chore A collection of chore like CI, remove not used code label Nov 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #26 (8f7805c) into main (89f7407) will increase coverage by 0.02%.
The diff coverage is 85.07%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   90.65%   90.68%   +0.02%     
==========================================
  Files          57       59       +2     
  Lines        2055     2072      +17     
==========================================
+ Hits         1863     1879      +16     
- Misses        192      193       +1     
Flag Coverage Δ
unittests 90.68% <85.07%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pydolphinscheduler/tasks/switch.py 100.00% <ø> (ø)
src/pydolphinscheduler/cli/commands.py 97.14% <50.00%> (ø)
src/pydolphinscheduler/core/workflow.py 81.86% <81.86%> (ø)
src/pydolphinscheduler/tasks/sub_workflow.py 83.33% <83.33%> (ø)
src/pydolphinscheduler/tasks/dependent.py 94.07% <87.50%> (-0.50%) ⬇️
src/pydolphinscheduler/core/task.py 93.67% <88.88%> (ø)
src/pydolphinscheduler/constants.py 100.00% <100.00%> (ø)
src/pydolphinscheduler/core/__init__.py 100.00% <100.00%> (ø)
src/pydolphinscheduler/core/process_definition.py 100.00% <100.00%> (+18.13%) ⬆️
src/pydolphinscheduler/core/yaml_workflow.py 91.82% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhongjiajie zhongjiajie added dep-main-repo Dependent on repository apache/dolphinscheduler incompatible labels Nov 16, 2022
@zhongjiajie
Copy link
Member Author

Should not merged until #15 merged, we need to change its keyword as well

@zhongjiajie
Copy link
Member Author

ref: apache/dolphinscheduler#12918

@zhongjiajie zhongjiajie marked this pull request as ready for review November 16, 2022 13:10
@zhongjiajie zhongjiajie merged commit afdd923 into apache:main Nov 16, 2022
1 check passed
@zhongjiajie zhongjiajie deleted the i-ch-name-wf branch November 16, 2022 13:34
@zhongjiajie
Copy link
Member Author

ref: apache/dolphinscheduler#12918

released after apache/dolphinscheduler:3.1.2

@zhongjiajie zhongjiajie removed the dep-main-repo Dependent on repository apache/dolphinscheduler label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A collection of chore like CI, remove not used code incompatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore] Change class name from process definition to workflow
3 participants