-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSIP-10][Unit Tests] Improve DolphinScheduler unit tests #10573
Comments
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
|
That's great! |
@SbloodyS Thx. Hope this will help and attract more new developers to submit PRs for DS and offer them an approach to get familiar with the code smoothly. |
great |
IMHO, we need some priorities, we could apply high priority to those modules where UT might play a more significant role regarding to code quality and application stability. |
@SbloodyS Could you please help add a |
We can make a list and mark it with priority. |
I got blocked by some unit test when developing a new feature and mocking some unusual stuff for nearly a day. I would like to update the UT docs with some examples which may help new developers bypass or overcome some pitfalls in UTs. May I ask whether it is possible to migrate this docs into main repo? @zhongjiajie https://dolphinscheduler.apache.org/en-us/community/development/unit-test.html Thanks |
Of cause, we can, do you interesting in this migration? |
Yes, I'd love to give a shot. |
BTW, we could fix the formatting and style errors incrementally, together with unit tests. See: #10963 |
I will update this issue with a more detailed refactoring plan as well as priorities later this week. |
I can get involved in the junit upgrade~ @EricGao888 |
@stalary Currently we are working on removing |
Okay, I can be a part of that. |
Usage of |
Great new |
Search before asking
Description
Unit Tests of high quality could not only improve the stability of Dolphin Scheduler, but also increase the readability of Dolphin Scheduler Code.
Use case
good first issue
. For new developers to this community, writing UT is a good way to understand the code logic and it is more intriguing than refactoring docs.Related issues
Action Items
Spotless
plugin into DolphinScheduler to enable developers to fix style / formatting errors incrementally: [Feature][style] Replace checkstyle plugin with spotless to automatically fix formatting errors #10963Powermock
: [Improvement][Test] Remove dependency of powermock #11405jUnit
dependency from4.x
to5.x
: [Improvement][UT] Upgrade junit to 5.+ #10976jUnit4
andPowermock
.good first issue
.method coverage criteria
and fix the style & formatting errors of relatedtest code
andtested code
. This one will be divided into sub-tasks later.Refactoring Guideline
method coverage
as refactoring metric to decouple UT cases as much as possible.jUnit 5
instead ofjUnit 4
.Powermock
in UTs and remove legacy UTs which containsPowermock
, see: [Improvement][Test] Remove dependency of powermock #11405 .Progress
Appendix: UT coverage of each module before refactoring
Are you willing to submit a PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: