[Improvement][all] Improvement checksyle

[MichaelDeSteven]

Search before asking

• I had searched in the issues and found no similar feature requirement.

Description

IMO, DS is not good enough in checksytle part.

When I want to compile or execute mvn command, I need to append - Dcheckstyle.skip. This is unfriendly for someone who is green hand and want to involved in this project.
I can improve this problem to make checkstyle pass in local environment.

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

• In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
• If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

[SbloodyS]

The current checkstyle detection is incremental detection, and full detection is not required to avoid many PR code conflicts caused by large-scale modifications.

[MichaelDeSteven]

The current checkstyle detection is incremental detection, and full detection is not required to avoid many PR code conflicts caused by large-scale modifications.

Or we can just simply appending a note that To start server when you execute mvn command, you may need to append - Dcheckstyle.skip in developer guide docs?

[fuchanghai]

@MichaelDeSteven @SbloodyS I suggest that when we modify a class, we do a code format check by the way。do we need to make a list like #10257 ?

[SbloodyS]

The current checkstyle detection is incremental detection, and full detection is not required to avoid many PR code conflicts caused by large-scale modifications.

Or we can just simply appending a note that To start server when you execute mvn command, you may need to append - Dcheckstyle.skip in developer guide docs?

That sounds good to me. cc @EricGao888 @zhongjiajie

[SbloodyS]

@MichaelDeSteven @SbloodyS I suggest that when we modify a class, we do a code format check by the way。do we need to make a list like #10257 ?

Currently, our CI detection is incremental.

[EricGao888]

The current checkstyle detection is incremental detection, and full detection is not required to avoid many PR code conflicts caused by large-scale modifications.

Or we can just simply appending a note that To start server when you execute mvn command, you may need to append - Dcheckstyle.skip in developer guide docs?

That sounds good to me. cc @EricGao888 @zhongjiajie

+1, before we fix all the style errors as planned in #10573 , I think instructing developers to use -Dcheckstyle.skip is a good idea. Thx.