Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [master/task] workflow with sub_process task can't be stop when running #14303

Closed
3 tasks done
HomminLee opened this issue Jun 7, 2023 · 4 comments
Closed
3 tasks done
Assignees
Labels
bug Something isn't working Stale

Comments

@HomminLee
Copy link
Contributor

HomminLee commented Jun 7, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

version 3.1.7

I want to stop the workflow with 'sub_process' task, but the workflow still 'ready stop' and 'sub_process' task still running.

Task state:
image

Workflow state:
image

'sub_process' task log:
image


Task state should be 'kill' instead of 'stop', cause TaskExecutionStatus only admit 'kill':

  public boolean isFinished() {
      return isSuccess() || isKill() || isFailure() || isPause();
  }

  public boolean isKill() {
      return this == TaskExecutionStatus.KILL;
  }

What you expected to happen

Stop workflow with 'sub_process' task

How to reproduce

  1. create A workflow with a shell task which will sleep 100s.
image
  1. create B workflow with a sub_process task which point to A workflow.
  2. start B workflow.
  3. after few seconds, stop B workflow instance.

Anything else

No response

Version

3.1.x

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@HomminLee HomminLee added bug Something isn't working Waiting for reply Waiting for reply labels Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information, version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

@rickchengx rickchengx removed the Waiting for reply Waiting for reply label Jun 8, 2023
@HomminLee
Copy link
Contributor Author

HomminLee commented Jun 9, 2023

@ruanwenjun What does 'BLOCK' workflow state mean? What is the corresponding task state for it?

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jul 10, 2023
@github-actions
Copy link

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
2 participants