[Fix-14303][Master] Workflow with sub_process task can't be stopped w…

[HomminLee]

Purpose of the pull request

fix #14303

Brief change log

When the sub workflow is finished, check the workflow state and transition to task status.

Verify this pull request

This pull request is already covered by existing tests, such as org.apache.dolphinscheduler.server.master.SubProcessTaskTest#testFinish.

[HomminLee]

@SbloodyS need a label to continue check

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (3.1.8-prepare@87481aa). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head b35a14d differs from pull request most recent head 0488491. Consider uploading reports for the commit 0488491 to get more accurate results

@@               Coverage Diff                @@
##             3.1.8-prepare   #14343   +/-   ##
================================================
  Coverage                 ?   38.20%           
  Complexity               ?     3980           
================================================
  Files                    ?      999           
  Lines                    ?    36902           
  Branches                 ?     4265           
================================================
  Hits                     ?    14097           
  Misses                   ?    21191           
  Partials                 ?     1614           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sonarcloud]

SonarCloud Quality Gate failed.   

8 Bugs
9 Vulnerabilities
1 Security Hotspot
772 Code Smells

27.6% Coverage
2.5% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[zhongjiajie]

why we workflow stop is kill?

[HomminLee]

STOP is workflow state, and KILL is task state. AFAK, task has no STOP state (TaskExecutionStatus has STOP state, but it has not been used anywhere). TaskExecutionStatus has code:

    public boolean isFinished() {
        return isSuccess() || isKill() || isFailure() || isPause();
    }

PAUSE workflow has PAUSE task, only KILL task state can match STOP workflow state, both of these indicate termination.

[caishunfeng]

👍

[caishunfeng]

The pr target should change to dev branch first?

[HomminLee]

The pr target should change to dev branch first?

In dev branch, sub_process has been refactor #13948 , and there is no relevant code anymore. BTW, I don't know if dev branch have the same issue.

[HomminLee]

The pr target should change to dev branch first?

In dev branch, sub_process has been refactor #13948 , and there is no relevant code anymore. BTW, I don't know if dev branch have the same issue.

I browsed sub_process code in dev branch, the new logic task framework only use three state: RUNNING, SUCCESS, FAILED.(Reference code: SubWorkflowAsyncTaskExecuteFunction#getAsyncTaskExecutionStatus) . Should the framework be improved?