Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Server] Kill yarn application command won't be execute when kill error #4862

Closed
dddyszy opened this issue Feb 24, 2021 · 2 comments · Fixed by #4936
Closed

[Bug][Server] Kill yarn application command won't be execute when kill error #4862

dddyszy opened this issue Feb 24, 2021 · 2 comments · Fixed by #4936
Labels
bug Something isn't working
Milestone

Comments

@dddyszy
Copy link
Contributor

dddyszy commented Feb 24, 2021

**For better global communication, Please describe it in English. If you feel the description in English is not clear, then you can append description in Chinese(just for Mandarin(CN)), thx! **
Describe the bug
There are two places used 'yarn application -kill',and both of them are in try catch.So if these is some exception in OSUtils.exeCmd(cmd), kill yarn application command won't be execute

To Reproduce
Steps to reproduce the behavior, for example:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
image
image
image

Which version of Dolphin Scheduler:
-[dev][release-1.3.5]

Additional context
Add any other context about the problem here.

Requirement or improvement

  • Please describe about your requirements or improvement suggestions.
@zhuangchong
Copy link
Contributor

If no contributor claims it, I'll fix it.

@dddyszy
Copy link
Contributor Author

dddyszy commented Feb 24, 2021

If no contributor claims it, I'll fix it.

just move it out of try catch.And i think we can do something to prevent kill error,improve pstree or other methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants