Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][Server] DB transaction failure #5150

Closed
ruanwenjun opened this issue Mar 25, 2021 · 1 comment
Closed

[Bug][Server] DB transaction failure #5150

ruanwenjun opened this issue Mar 25, 2021 · 1 comment

Comments

@ruanwenjun
Copy link
Member

Describe the bug
When MasterSchedulerService handle command by ProcessService.handleCommand, I find the @Transaction annotation in the ProcessService doesn't work. Sometimes this may cause serious problem.

To Reproduce
Maybe it is hard to reproduce, but you can make an error in ProcessService.moveToErrorCommand, then you will find the issue.

Which version of Dolphin Scheduler:
-[1.3.6]
-[dev]

Requirement or improvement
It is because Server module remove the spring-boot dependency, so it will not auto enable transaction manager. So we need to open manually.
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this issue Mar 25, 2021
@ruanwenjun
[Bug][Server] DB transaction failure apache#5150
0ec8738
@ruanwenjun ruanwenjun mentioned this issue Mar 25, 2021
Merged
@xingchun-chen xingchun-chen mentioned this issue Mar 26, 2021
Closed
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this issue Mar 26, 2021
@ruanwenjun
[Bug][Server] DB transaction failure apache#5150
2587078
CalvinKirs pushed a commit that referenced this issue Mar 29, 2021
@ruanwenjun
[Bug][Server] DB transaction failure #5150 (#5152)
573252f
@CalvinKirs
Copy link
Member

close by #5152

@chengshiwen chengshiwen mentioned this issue Apr 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CalvinKirs @ruanwenjun