Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][api] When sleep is included in a shell task, cannot kill the task #5199

Closed
xingchun-chen opened this issue Apr 2, 2021 · 1 comment · Fixed by #5212
Closed

[Bug][api] When sleep is included in a shell task, cannot kill the task #5199

xingchun-chen opened this issue Apr 2, 2021 · 1 comment · Fixed by #5212
Milestone
1.3.6-release

Comments

@xingchun-chen
Copy link
Contributor

image
image

Which version of Dolphin Scheduler:
-[1.3.6-prepare]
@xingchun-chen xingchun-chen added this to the 1.3.6-release milestone Apr 2, 2021
@ruanwenjun
Copy link
Member

ruanwenjun commented Apr 3, 2021 •
edited

I can kill the task, after install the pstree on my environment.
And the task can be killed successfully.
image

But there is still an error, that I don't have permission to kill the parent process, but I can kill the subprocess, so the task is still be killed.

-+- 20788 root sudo -u ruanwenjun sh /tmp/dolphinscheduler/exec/process/1/4/73/76/4_73_76.command
 \-+- 20789 ruanwenjun sh /tmp/dolphinscheduler/exec/process/1/4/73/76/4_73_76.command
   \-+- 20795 ruanwenjun sh /tmp/dolphinscheduler/exec/process/1/4/73/76/4_73_76.command
     \--- 20796 ruanwenjun sleep 20

org.apache.dolphinscheduler.server.worker.processor.TaskKillProcessor:[131] - process id:20788, cmd:sudo -u ruanwenjun kill -9 20788 20789 20795 20796
org.apache.dolphinscheduler.common.shell.AbstractShell$ExitCodeException: kill: 20788: Operation not permitted

@CalvinKirs CalvinKirs mentioned this issue Apr 6, 2021
Merged
CalvinKirs pushed a commit that referenced this issue Apr 6, 2021
@ruanwenjun
[Improvement][Worker] Kill task error(#5199) (#5212)
4a1303b
@CalvinKirs CalvinKirs mentioned this issue Apr 6, 2021
Merged
lenboo pushed a commit that referenced this issue Apr 6, 2021
@CalvinKirs
[1.3.6-prepare][Improvement][Worker] Throw operation not permitted ex…
5ec72aa 
…ception when kill shell task (#5214)

pr    #5212
issue #5199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.6-release
2 participants
@ruanwenjun @xingchun-chen