-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Added local file configuration guide for resource center #10264
Conversation
…missions` in en and zh docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for you contribution.
@zhongjiajie Do you have better suggestions?
Hi @GavinGYM could we combine this PR to #10265, I think is better to submit PR together with code and docs instead of separating them WDYT @SbloodyS @QuakeWang |
|
||
Configure the file in the following paths: `api-server/conf/common.properties` and `worker-server/conf/common.properties`. | ||
|
||
- Change 'data.basedir.path' to the local directory path. Please make sure the directory exists and the user who deploy dolphinscheduler have read and write permissions, such as: `data.basedir.path=/tmp/dolphinscheduler`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the previous comment
- Change 'data.basedir.path' to the local directory path. Please make sure the directory exists and the user who deploy dolphinscheduler have read and write permissions, such as: `data.basedir.path=/tmp/dolphinscheduler`. | |
- Change `data.basedir.path` to the local directory path. Please make sure the directory exists and the user who deploy dolphinscheduler have read and write permissions, such as: `data.basedir.path=/tmp/dolphinscheduler`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will auto-create directory if not exists, so maybe we could delete the Please make sure the directory exists
Lines 103 to 112 in 996790c
private void initHdfsPath() { | |
Path path = new Path(RESOURCE_UPLOAD_PATH); | |
try { | |
if (!fs.exists(path)) { | |
fs.mkdirs(path); | |
} | |
} catch (Exception e) { | |
logger.error(e.getMessage(), e); | |
} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @GavinGYM
I got it, the PR author is not the same, pls ignore this comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank @GavinGYM
BTW, capitalizing the first word of a sentence is enough for both PR or issue title @GavinGYM |
My pleasure. |
Got it. I'll pay attention next time. |
* Added Local File Resource Configuration Guide to the document. * Removed contents with windows features in the documents and improved expression. * Specify `the user who deploy dolphinscheduler have read and write permissions` in en and zh docs. Co-authored-by: xiangzihao <460888207@qq.com> (cherry picked from commit 2294160)
…he#10264) * Added Local File Resource Configuration Guide to the document. * Removed contents with windows features in the documents and improved expression. * Specify `the user who deploy dolphinscheduler have read and write permissions` in en and zh docs. Co-authored-by: xiangzihao <460888207@qq.com>
Purpose of the pull request
This pull request added Local File Resource Configuration Guide to the document, updated file path for common.properties, and removed unnecessary tips.
Brief change log
Modified docs/en/guide/resource/configuration.md
Modified docs/zh/guide/resource/configuration.md
Verify this pull request
This pull request is code cleanup without any test coverage.