Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade log4j #10359

Merged
merged 2 commits into from
Jun 9, 2022
Merged

upgrade log4j #10359

merged 2 commits into from
Jun 9, 2022

Conversation

pjfanning
Copy link
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@pjfanning pjfanning marked this pull request as draft June 3, 2022 08:24
@codecov-commenter
Copy link

Codecov Report

Merging #10359 (dd54ef5) into dev (0bf4043) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #10359      +/-   ##
============================================
- Coverage     40.18%   40.18%   -0.01%     
+ Complexity     4727     4726       -1     
============================================
  Files           871      871              
  Lines         35375    35375              
  Branches       3943     3943              
============================================
- Hits          14215    14214       -1     
  Misses        19731    19731              
- Partials       1429     1430       +1     
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bf4043...dd54ef5. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kezhenxu94
Copy link
Member

Any update @pjfanning

@pjfanning pjfanning marked this pull request as ready for review June 9, 2022 07:44
@pjfanning
Copy link
Contributor Author

@kezhenxu94 the change in this PR is the only place where dolphinscheduler explicitly uses an old version of log4j. There are quite a few old dependencies of dolphinscheduler that are bringing in old log4j dependencies though.

  • hive-common
  • spring-boot-starter
  • zookeeper has a dependency on log4jv1

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is just an E2E dependency and they won't be included in distribution package though

@kezhenxu94 kezhenxu94 merged commit f90f0f8 into apache:dev Jun 9, 2022
@pjfanning pjfanning deleted the upgrade-log4j branch June 9, 2022 08:12
@devosend devosend added this to the 3.0.0-beta-2 milestone Jun 18, 2022
devosend pushed a commit that referenced this pull request Jun 18, 2022
(cherry picked from commit f90f0f8)
ITBOX-ITBOY pushed a commit to ITBOX-ITBOY/dolphinscheduler that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants