Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add how to set the alarm mailbox in faq #10401

Merged
merged 6 commits into from
Jun 17, 2022
Merged

[Doc] Add how to set the alarm mailbox in faq #10401

merged 6 commits into from
Jun 17, 2022

Conversation

liubo1990
Copy link
Contributor

@liubo1990 liubo1990 commented Jun 10, 2022 •
edited

Purpose of the pull request

Fixed #10384

Brief change log

Added the steps of how to set the alarm mailbox in faq.md

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@liubo1990 liubo1990 changed the title modify faq.md [Fix][Doc]Add the steps of how to set the alarm mailbox in faq.md Jun 10, 2022
@liubo1990 liubo1990 mentioned this pull request Jun 10, 2022
Closed
3 tasks
@SbloodyS SbloodyS self-assigned this Jun 10, 2022
@SbloodyS SbloodyS added bug Something isn't working first time contributor First-time contributor document labels Jun 10, 2022
@SbloodyS SbloodyS added this to the 3.0.0-beta-2 milestone Jun 10, 2022
SbloodyS
SbloodyS reviewed Jun 10, 2022
View reviewed changes
docs/docs/zh/faq.md Outdated Show resolved Hide resolved
zhongjiajie
zhongjiajie requested changes Jun 12, 2022
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the English language and latest version of DolphinScheduler for the screenshot

@zhongjiajie
Copy link
Member

Please use the English language and latest version of DolphinScheduler for the screenshot

Please only use English version screenshot in both English and Chinese version document @liubo1990

@SbloodyS SbloodyS assigned liubo1990 and unassigned SbloodyS Jun 13, 2022
@liubo1990
Copy link
Contributor Author

Please use the English language and latest version of DolphinScheduler for the screenshot

Please only use English version screenshot in both English and Chinese version document @liubo1990

@zhongjiajie ，ok

@zhongjiajie
Copy link
Member

img check failed https://github.com/apache/dolphinscheduler/runs/6879865864?check_suite_focus=true, please remove the img '/img/faq_alter2.png', '/img/faq_alter1.png', '/img/faq_alter3.png'

@liubo1990
Copy link
Contributor Author

img check failed https://github.com/apache/dolphinscheduler/runs/6879865864?check_suite_focus=true, please remove the img '/img/faq_alter2.png', '/img/faq_alter1.png', '/img/faq_alter3.png'

The corresponding image has been removed, it should be fine now.

SbloodyS
SbloodyS approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you have any better suggestions? @zhongjiajie

@zhongjiajie zhongjiajie changed the title [Fix][Doc]Add the steps of how to set the alarm mailbox in faq.md [Doc] Add how to set the alarm mailbox in faq Jun 17, 2022
@zhongjiajie zhongjiajie merged commit b8d5e78 into apache:dev Jun 17, 2022
@zhongjiajie
Copy link
Member

LGTM. Do you have any better suggestions? @zhongjiajie

nop, merging

devosend pushed a commit that referenced this pull request Jun 18, 2022
@liubo1990 @devosend
[Doc] Add how to set the alarm mailbox in faq (#10401)
248a85d 
(cherry picked from commit b8d5e78)
hstdream pushed a commit to hstdream/dolphinscheduler that referenced this pull request Jun 23, 2022
@liubo1990
[Doc] Add how to set the alarm mailbox in faq (apache#10401)
d391bd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@SbloodyS SbloodyS SbloodyS approved these changes

@Tianqi-Dotes Tianqi-Dotes Awaiting requested review from Tianqi-Dotes

Assignees

@liubo1990 liubo1990

Labels
bug Something isn't working document first time contributor First-time contributor
Projects
None yet
Milestone
3.0.0-beta-2
Development

Successfully merging this pull request may close these issues.

[Bug] [Doc] The faq.md file is not updated in time
3 participants
@liubo1990 @zhongjiajie @SbloodyS