[Fix-10425]Recovery LDAP Config #10429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #10429 +/- ##
============================================
+ Coverage 40.52% 40.55% +0.02%
- Complexity 4770 4774 +4
============================================
Files 877 878 +1
Lines 35698 35741 +43
Branches 3969 3969
============================================
+ Hits 14468 14493 +25
- Misses 19786 19805 +19
+ Partials 1444 1443 -1
Continue to review full report at Codecov.
|
|
Hi @liqingwang please update this security config description into doc, see https://dolphinscheduler.apache.org/en-us/docs/latest/user_doc/architecture/configuration.html |
|
SonarCloud Quality Gate failed. |
kezhenxu94
approved these changes
Jun 14, 2022
|
This PR is ready too, and for the configuration part, I'll open another pr to upgrade to the newest. @zhongjiajie |
devosend
pushed a commit
that referenced
this pull request
Jun 18, 2022
* recovery ladp code * add ldap config in doc (cherry picked from commit 0efcd5c)
3 tasks
hstdream
pushed a commit
to hstdream/dolphinscheduler
that referenced
this pull request
Jun 23, 2022
* recovery ladp code * add ldap config in doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Due to 4114cb0#diff-f2f54230647b5ed6920efc032cd61c4dc2acd8f728ad0f43aef1e8fd3f9793ed , dev branch has no LDAP config in the YAML file. I recovery LDAP config.
Brief change log
dolphinscheduler-api/src/main/resources/application.yaml
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/ldap/LdapService.java
dolphinscheduler-standalone-server/src/main/resources/application.yaml
Verify this pull request
This pull request is already covered by existing tests, such as (please describe tests).
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/security/impl/ldap/LdapAuthenticatorTest.java
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/security/impl/ldap/LdapServiceTest.java
part of #10425