Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix-10400]Fix K8s deployment bitnami version error #10567

Merged
merged 2 commits into from
Jun 24, 2022
Merged

[Fix-10400]Fix K8s deployment bitnami version error #10567

merged 2 commits into from
Jun 24, 2022

Conversation

qingwli
Copy link
Member

@qingwli qingwli commented Jun 23, 2022

@SbloodyS SbloodyS added bug Something isn't working backend labels Jun 23, 2022
@SbloodyS SbloodyS added this to the 3.0.0-beta-3 milestone Jun 23, 2022
kezhenxu94
kezhenxu94 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #10567 (b249dff) into dev (1b1a567) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #10567      +/-   ##
============================================
- Coverage     40.92%   40.91%   -0.01%     
+ Complexity     4873     4872       -1     
============================================
  Files           895      895              
  Lines         36201    36201              
  Branches       3986     3986              
============================================
- Hits          14815    14813       -2     
+ Misses        19924    19921       -3     
- Partials       1462     1467       +5
Impacted Files Coverage Δ
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.00% <0.00%> (-1.39%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 45.65% <0.00%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 773ebc9...b249dff. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@qingwli
Copy link
Member Author

qingwli commented Jun 24, 2022

PTAL @zhongjiajie

SbloodyS
SbloodyS approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS merged commit 0b377f7 into apache:dev Jun 24, 2022
@qingwli
Copy link
Member Author

qingwli commented Jun 24, 2022

This PR impacted K8s deployed, need to change the milestone to 300b2. Thx @SbloodyS

@SbloodyS
Copy link
Member

This PR impacted K8s deployed, need to change the milestone to 300b2. Thx @SbloodyS

PTAL @devosend

@zhongjiajie
Copy link
Member

This PR impacted K8s deployed, need to change the milestone to 300b2. Thx @SbloodyS

Agree with that, I change milestone to 300b2, and FYI @SbloodyS @devosend

devosend pushed a commit that referenced this pull request Jun 28, 2022
@qingwli @devosend
[Fix-10400]Fix K8s deployment bitnami version error (#10567)
67bc8a1 
* Fix k8s bitnami bug

* add comments

(cherry picked from commit 0b377f7)
@zhongjiajie zhongjiajie mentioned this pull request Jun 29, 2022
Merged
@qingwli qingwli deleted the fix-k8s-bug branch September 7, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongjiajie zhongjiajie zhongjiajie left review comments

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@SbloodyS SbloodyS SbloodyS approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

Assignees

@qingwli qingwli

Labels
backend bug Something isn't working
Projects
DolphinScheduler Roadmap
Archived in project
Milestone
3.0.0-beta-2
Development

Successfully merging this pull request may close these issues.

Deploy kubernetes according to the official website document, failed!
5 participants
@qingwli @codecov-commenter @SbloodyS @zhongjiajie @kezhenxu94