Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature-10683][Task Plugin] Add Java Task Plugin. #10689

Merged
merged 42 commits into from
Sep 9, 2022
Merged

[Feature-10683][Task Plugin] Add Java Task Plugin. #10689

merged 42 commits into from
Sep 9, 2022

Conversation

106umao
Copy link
Contributor

@106umao 106umao commented Jun 30, 2022 •
edited by SbloodyS
Loading

This feature close #10683

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@SbloodyS SbloodyS added feature new feature UI ui and front end related backend labels Jun 30, 2022
@SbloodyS SbloodyS added this to the 3.1.0-alpha milestone Jun 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022 •
edited
Loading

Codecov Report

Merging #10689 (6fc1e27) into dev (efedc9a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #10689      +/-   ##
============================================
- Coverage     38.66%   38.64%   -0.02%     
+ Complexity     4038     4035       -3     
============================================
  Files           992      991       -1     
  Lines         36573    36546      -27     
  Branches       4266     4264       -2     
============================================
- Hits          14141    14124      -17     
+ Misses        20806    20800       -6     
+ Partials       1626     1622       -4
Impacted Files Coverage Δ
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 43.54% <0.00%> (-6.46%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 42.55% <0.00%> (-2.13%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 51.38% <0.00%> (-1.39%) ⬇️
...nscheduler/plugin/task/api/model/TaskResponse.java

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

zhongjiajie
zhongjiajie reviewed Jul 6, 2022
View reviewed changes
docs/docs/en/guide/task/java.md Outdated Show resolved Hide resolved
docs/docs/en/guide/task/java.md Outdated Show resolved Hide resolved
docs/docs/zh/guide/task/java.md Outdated Show resolved Hide resolved
docs/docs/en/guide/task/java.md Outdated Show resolved Hide resolved
@pinkhello
Copy link
Contributor

SonarCloud CI failed

@pinkhello
Copy link
Contributor

OWASP Dependency Check CI Failed

zhuangchong
zhuangchong requested changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the JAVA task documentation link in the docsdev.js file.

https://github.com/apache/dolphinscheduler/blob/dev/docs/configs/docsdev.js

dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-main-jar.ts Outdated Show resolved Hide resolved
@106umao
Copy link
Contributor Author

106umao commented Jul 14, 2022 •
edited
Loading

You need to add the JAVA task documentation link in the docsdev.js file.

https://github.com/apache/dolphinscheduler/blob/dev/docs/configs/docsdev.js

thx, have done

@106umao 106umao requested a review from zhuangchong July 14, 2022 14:58
zhuangchong
zhuangchong previously approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

106umao and others added 15 commits September 8, 2022 16:55
@106umao
adjust the exception type.
d0f3196
@106umao
update cached the regex, add link into docsdev.js for java task
4614f32
@106umao
update remvoe ; in user-main-jar.ts
31c1b23
@106umao
fix typo
f2f23a7 
resolve the conflict, modify @DaTa to e.g. @Setter, @getter

modify the construction way for java command path.

fix typo
@106umao @EricGao888 @zhongjiajie
Update docs/docs/en/guide/task/java.md
f861b1f 
Apply suggestions from code review

Co-authored-by: Eric Gao <ericgao.apache@gmail.com>
Co-authored-by: Jiajie Zhong <zhongjiajie955@gmail.com>
@106umao
adjust the format of table.
658cca2
@106umao
cover exception unit test
5c19e0c
@106umao
optimize locales of project.
9720a51
@106umao
fix typo of the java.md and optimize the code comment of java file.
7c1dbda
@106umao
optimize log output.
5e059c2
@106umao
change lombok, remove data comment.
480013d 
optimize log and constant
@106umao
fix build failed
f5f0fb0 
optimize
@106umao
resolve conflict
8491318
@106umao @ruanwenjun
Update dolphinscheduler-task-plugin/dolphinscheduler-task-java/src/ma…
ad6a7c1 
…in/java/org/apache/dolphinscheduler/plugin/task/java/JavaParameters.java

Co-authored-by: Wenjun Ruan <wenjun@apache.org>
@106umao
resolve conflict
df2a216
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
2.0% 2.0% Duplication

@106umao 106umao requested review from ruanwenjun and zhuangchong and removed request for zhuangchong and ruanwenjun September 9, 2022 02:28
zhuangchong
zhuangchong approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhuangchong zhuangchong dismissed Amy0104’s stale review September 9, 2022 02:36

It has been modified.

@zhuangchong zhuangchong merged commit 5d9331f into apache:dev Sep 9, 2022
@EricGao888
Copy link
Member

@106umao Congrats! Thanks for the contributions : )

xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Sep 10, 2022
@106umao @xdu-chenrj
[Feature-10683][Task Plugin] Add Java Task Plugin. (apache#10689)
4e1b0c8
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Sep 10, 2022
@106umao @xdu-chenrj
[Feature-10683][Task Plugin] Add Java Task Plugin. (apache#10689)
4988be9
@caishunfeng caishunfeng modified the milestones: 3.1.0, 3.2.0 Sep 19, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
@106umao @xdu-chenrj
[Feature-10683][Task Plugin] Add Java Task Plugin. (apache#10689)
d821446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinkhello pinkhello pinkhello left review comments

@zhongjiajie zhongjiajie zhongjiajie left review comments

@kezhenxu94 kezhenxu94 kezhenxu94 left review comments

@Amy0104 Amy0104 Amy0104 left review comments

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@zhuangchong zhuangchong zhuangchong approved these changes

@SbloodyS SbloodyS SbloodyS left review comments

@EricGao888 EricGao888 EricGao888 left review comments

Assignees

@106umao 106umao

Labels
backend document feature new feature UI ui and front end related
Projects
DolphinScheduler Roadmap
Status: Done
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

[Feature][Task Plugin] add java task plugin.