Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Optimizing data source centers #12292

Merged
merged 8 commits into from
Oct 19, 2022
Merged

[Feature] Optimizing data source centers #12292

merged 8 commits into from
Oct 19, 2022

Conversation

labbomb
Copy link
Member

@labbomb labbomb commented Oct 10, 2022

Purpose of the pull request

Add data source type page

Brief change log

  • Added a dialog box for selecting the data source type
  • Delete the original data source type drop-down selection

image

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added the UI ui and front end related label Oct 10, 2022
songjianet
songjianet previously approved these changes Oct 10, 2022
Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devosend
devosend previously approved these changes Oct 10, 2022
Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@labbomb labbomb dismissed stale reviews from devosend and songjianet via 6ef5414 October 10, 2022 07:20
@caishunfeng
Copy link
Contributor

@labbomb Please add some pr description, thanks~

@labbomb
Copy link
Member Author

labbomb commented Oct 11, 2022

@labbomb Please add some pr description, thanks~

down

@caishunfeng caishunfeng added the feature new feature label Oct 13, 2022
@caishunfeng caishunfeng changed the title feat: Optimizing data source centers [Feature] Optimizing data source centers Oct 13, 2022
@github-actions github-actions bot added the e2e e2e test label Oct 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Merging #12292 (4448ad2) into dev (bd7e761) will decrease coverage by 0.50%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #12292      +/-   ##
============================================
- Coverage     39.71%   39.21%   -0.51%     
- Complexity     4193     4212      +19     
============================================
  Files          1016     1040      +24     
  Lines         38049    38795     +746     
  Branches       4363     4460      +97     
============================================
+ Hits          15112    15214     +102     
- Misses        21192    21807     +615     
- Partials       1745     1774      +29     
Impacted Files Coverage Δ
.../apache/dolphinscheduler/rpc/client/RpcClient.java 0.00% <0.00%> (-100.00%) ⬇️
...che/dolphinscheduler/rpc/protocol/RpcProtocol.java 0.00% <0.00%> (-100.00%) ⬇️
...e/dolphinscheduler/rpc/client/RpcRequestCache.java 0.00% <0.00%> (-100.00%) ⬇️
...e/dolphinscheduler/rpc/protocol/MessageHeader.java 0.00% <0.00%> (-100.00%) ⬇️
...dolphinscheduler/rpc/common/ThreadPoolManager.java 0.00% <0.00%> (-100.00%) ⬇️
...dolphinscheduler/rpc/serializer/RpcSerializer.java 0.00% <0.00%> (-100.00%) ⬇️
...lphinscheduler/rpc/common/AbstractRpcCallBack.java 0.00% <0.00%> (-100.00%) ⬇️
...pache/dolphinscheduler/rpc/codec/NettyEncoder.java 0.00% <0.00%> (-93.75%) ⬇️
...he/dolphinscheduler/rpc/client/ConsumerConfig.java 0.00% <0.00%> (-90.91%) ⬇️
...pache/dolphinscheduler/rpc/protocol/EventType.java 0.00% <0.00%> (-90.00%) ⬇️
... and 135 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

@caishunfeng caishunfeng added this to the 3.2.0 milestone Oct 18, 2022
@labbomb labbomb closed this Oct 18, 2022
@labbomb labbomb deleted the labbomb branch October 18, 2022 14:32
@labbomb labbomb restored the labbomb branch October 19, 2022 01:13
@caishunfeng caishunfeng reopened this Oct 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The front end part LGTM.

@caishunfeng caishunfeng merged commit a11892a into apache:dev Oct 19, 2022
@labbomb labbomb deleted the labbomb branch October 19, 2022 03:37
Chris-Arith pushed a commit to Chris-Arith/dolphinscheduler that referenced this pull request Oct 26, 2022
* feat: Optimizing data source centers

* add e2e class

* update datasource e2e

* fix hive e2e

* fix: Modify the source type parameter

Co-authored-by: caishunfeng <caishunfeng2021@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e e2e test feature new feature UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants