-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement] Migrate all UT cases from jUnit4 to jUnit5 in dao module #12328
Conversation
dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/AlertDaoTest.java
Outdated
Show resolved
Hide resolved
...nscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/upgrade/WorkerGroupDaoTest.java
Outdated
Show resolved
Hide resolved
...nscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/upgrade/WorkerGroupDaoTest.java
Fixed
Show resolved
Hide resolved
...nscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/upgrade/WorkerGroupDaoTest.java
Fixed
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #12328 +/- ##
============================================
- Coverage 38.94% 38.92% -0.02%
+ Complexity 4178 4175 -3
============================================
Files 1040 1040
Lines 38797 38797
Branches 4460 4462 +2
============================================
- Hits 15109 15103 -6
- Misses 21919 21926 +7
+ Partials 1769 1768 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
9db9836
to
5481dc9
Compare
Seems network problems, have rerun the failed CI. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
apache#12328) * [improvement] Migrate all UT cases from jUnit4 to jUnit5 in dao module Co-authored-by: Jackie <‘2875334588@qq.com’>
apache#12328) * [improvement] Migrate all UT cases from jUnit4 to jUnit5 in dao module Co-authored-by: Jackie <‘2875334588@qq.com’>
Purpose of the pull request
Brief change log
this close #12319