Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Athena Datasource]Fix datasource other params illegal #13032

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

Jrebel-i
Copy link
Contributor

@Jrebel-i Jrebel-i commented Nov 28, 2022

Purpose of the pull request

Add athena datasource normally
This PR closes #13024

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@Jrebel-i Jrebel-i changed the title Fix Bug [Athena Datasource] datasource other params illegal [Bug] [Athena Datasource]Fix datasource other params illegal Nov 28, 2022
@SbloodyS SbloodyS added bug Something isn't working first time contributor First-time contributor 3.1.x for 3.1.x version labels Nov 30, 2022
@SbloodyS SbloodyS added this to the 3.1.2 milestone Nov 30, 2022
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passed. Thanks.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Merging #13032 (e52f17e) into dev (32a8241) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev   #13032      +/-   ##
============================================
- Coverage     39.36%   39.33%   -0.03%     
+ Complexity     4279     4275       -4     
============================================
  Files          1069     1069              
  Lines         40180    40180              
  Branches       4607     4611       +4     
============================================
- Hits          15815    15804      -11     
- Misses        22586    22597      +11     
  Partials       1779     1779              
Impacted Files Coverage Δ
...ce/api/datasource/AbstractDataSourceProcessor.java 18.51% <100.00%> (ø)
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 43.54% <0.00%> (-7.26%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 51.19% <0.00%> (-1.20%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zhuangchong zhuangchong modified the milestones: 3.1.2, 3.1.3 Dec 7, 2022
@zhuangchong zhuangchong modified the milestones: 3.1.3, 3.1.4 Jan 3, 2023
@zhuangchong zhuangchong modified the milestones: 3.1.4, 3.1.5 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version backend bug Something isn't working first time contributor First-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Athena Datasource] datasource other params illegal
4 participants