Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][Master] fix task failure continue #13155

Merged
merged 1 commit into from Mar 30, 2023
Merged

[Bug][Master] fix task failure continue #13155

merged 1 commit into from Mar 30, 2023

Conversation

ititdog
Copy link
Contributor

@ititdog ititdog commented Dec 12, 2022

What happened
When it exists in the conditional node, that is, the task flow can execute and complete the DAG task correctly, at this time, the task flow status cannot be considered as a failure because of a node error in the task flow. This will cause dependent nodes not to correctly identify the task flow state
What you expected to happen
xxx

How to reproduce

  1. Use conditional nodes
  2. Let the task flow go to the failure branch of the conditions node

Anything else
No response

Version
3.0.3, 3.0.4, 3.1.x, dev

@davidzollo davidzollo added the first time contributor First-time contributor label Dec 12, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 12, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

28.5% 28.5% Coverage
9.8% 9.8% Duplication

@caishunfeng caishunfeng added bug Something isn't working 3.0.x 3.1.x for 3.1.x version labels Dec 18, 2022
@caishunfeng
Copy link
Contributor

Hi @ititdog please use the correct title, thanks.
See https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md

@EricGao888 EricGao888 self-requested a review December 23, 2022 15:34
caishunfeng
caishunfeng approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng changed the title Update WorkflowExecuteRunnable.java [Bug][Master] fix task failure continue Mar 30, 2023
@caishunfeng caishunfeng merged commit d64004a into apache:dev Mar 30, 2023
1 check passed
@zhongjiajie zhongjiajie added this to the 3.0.5 milestone Mar 30, 2023
zhongjiajie pushed a commit that referenced this pull request Mar 30, 2023
@ititdog @zhongjiajie
Update WorkflowExecuteRunnable.java (#13155)
33f2caf 
(cherry picked from commit d64004a)
zhuangchong pushed a commit that referenced this pull request Mar 31, 2023
@ititdog @zhuangchong
Update WorkflowExecuteRunnable.java (#13155)
68c8d55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

@EricGao888 EricGao888 Awaiting requested review from EricGao888

Assignees

@ititdog ititdog

Labels
3.1.x for 3.1.x version backend bug Something isn't working first time contributor First-time contributor
Projects
None yet
Milestone
3.0.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ititdog @caishunfeng @zhongjiajie @davidzollo